From b6704586875c6e8dbfe9fe142709a0404f20c582 Mon Sep 17 00:00:00 2001 From: "Frank A. Krueger" Date: Sun, 26 Nov 2017 12:18:33 -0800 Subject: [PATCH 01/36] Fix Editor events --- Ooui.Forms/Renderers/EditorRenderer.cs | 18 +++++++++--------- Ooui/TextArea.cs | 4 ++-- Samples/XamlPreviewPage.xaml.cs | 22 +++++++++++++++------- 3 files changed, 26 insertions(+), 18 deletions(-) diff --git a/Ooui.Forms/Renderers/EditorRenderer.cs b/Ooui.Forms/Renderers/EditorRenderer.cs index 880c51e..a61a7e1 100644 --- a/Ooui.Forms/Renderers/EditorRenderer.cs +++ b/Ooui.Forms/Renderers/EditorRenderer.cs @@ -19,9 +19,9 @@ namespace Ooui.Forms.Renderers if (disposing) { if (Control != null) { - Control.Changed -= HandleChanged; + Control.Inputted -= HandleChanged; //Control.Started -= OnStarted; - //Control.Ended -= OnEnded; + Control.Changed -= OnEnded; } } @@ -40,9 +40,9 @@ namespace Ooui.Forms.Renderers ClassName = "form-control" }); - Control.Changed += HandleChanged; + Control.Inputted += HandleChanged; //Control.Started += OnStarted; - //Control.Ended += OnEnded; + Control.Changed += OnEnded; } UpdateText (); @@ -75,13 +75,13 @@ namespace Ooui.Forms.Renderers void HandleChanged (object sender, EventArgs e) { - ElementController.SetValueFromRenderer (Editor.TextProperty, Control.Text); + ElementController.SetValueFromRenderer (Editor.TextProperty, Control.Value); } void OnEnded (object sender, EventArgs eventArgs) { - if (Control.Text != Element.Text) - ElementController.SetValueFromRenderer (Editor.TextProperty, Control.Text); + if (Control.Value != Element.Text) + ElementController.SetValueFromRenderer (Editor.TextProperty, Control.Value); Element.SetValue (VisualElement.IsFocusedPropertyKey, false); ElementController.SendCompleted (); @@ -108,8 +108,8 @@ namespace Ooui.Forms.Renderers void UpdateText () { - if (Control.Text != Element.Text) - Control.Text = Element.Text; + if (Control.Value != Element.Text) + Control.Value = Element.Text; } void UpdateTextAlignment () diff --git a/Ooui/TextArea.cs b/Ooui/TextArea.cs index 94ca6fe..76b3a1d 100644 --- a/Ooui/TextArea.cs +++ b/Ooui/TextArea.cs @@ -42,12 +42,12 @@ namespace Ooui public TextArea (string text) : this () { - Text = text; + Value = text; } protected override bool TriggerEventFromMessage (Message message) { - if (message.TargetId == Id && message.MessageType == MessageType.Event && message.Key == "change") { + if (message.TargetId == Id && message.MessageType == MessageType.Event && (message.Key == "change" || message.Key == "input")) { // Don't need to notify here because the base implementation will fire the event val = message.Value != null ? Convert.ToString (message.Value) : ""; } diff --git a/Samples/XamlPreviewPage.xaml.cs b/Samples/XamlPreviewPage.xaml.cs index 2a7ba12..08462bd 100644 --- a/Samples/XamlPreviewPage.xaml.cs +++ b/Samples/XamlPreviewPage.xaml.cs @@ -29,18 +29,26 @@ namespace Samples