From df09f87e26bdfa305ffd1e4f4a197c4dae8bea5d Mon Sep 17 00:00:00 2001 From: Luca Date: Fri, 2 Oct 2020 14:15:24 +0200 Subject: [PATCH] Chnaged the pull request templates to be onefile where you have to select the type of pull request. Reasoning is the very user unfriendly way multiple templates can be used (only over specific urls) --- .../bug_fix.md => PULL_REQUEST_TEMPLATE.md} | 20 ++++++------ .../feature_implementation.md | 32 ------------------- 2 files changed, 10 insertions(+), 42 deletions(-) rename .github/{PULL_REQUEST_TEMPLATE/bug_fix.md => PULL_REQUEST_TEMPLATE.md} (59%) delete mode 100644 .github/PULL_REQUEST_TEMPLATE/feature_implementation.md diff --git a/.github/PULL_REQUEST_TEMPLATE/bug_fix.md b/.github/PULL_REQUEST_TEMPLATE.md similarity index 59% rename from .github/PULL_REQUEST_TEMPLATE/bug_fix.md rename to .github/PULL_REQUEST_TEMPLATE.md index 44f46925..41013694 100644 --- a/.github/PULL_REQUEST_TEMPLATE/bug_fix.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,26 +1,26 @@ --- -name: Bugfix -about: Thanks for the submission of a bugfix -title: '' -labels: bug -assignees: '' - +Title --- **Important note** Please note that only PrestoN is able to merge Pull Requests into master. +**Pull Request Type** +Please select what type of pull request this is: +- [ ] Bugfix +- [ ] Feature Implementation + **Related issue** -Please link the issue your bugfix is referring to. +Please link the issue your pull request is referring to. **Description** -Please write a clear and concise description of what the bugfix does. +Please write a clear and concise description of what the pull request does. **Screenshots (if appropriate)** Please add before and after screenshots if there is a visible change. -**Testing (for fixes that are not easily understandable)** -Has this bugfix been tested? +**Testing (for code that is not small enough to be easily understandable)** +Has this pull request been tested? Please describe shortly how you tested it and whether there are any ramifications remaining. **Desktop (please complete the following information):** diff --git a/.github/PULL_REQUEST_TEMPLATE/feature_implementation.md b/.github/PULL_REQUEST_TEMPLATE/feature_implementation.md deleted file mode 100644 index e0240efc..00000000 --- a/.github/PULL_REQUEST_TEMPLATE/feature_implementation.md +++ /dev/null @@ -1,32 +0,0 @@ ---- -name: Feature implementation -about: Thanks for the implementation of a new feature -title: '' -labels: enhancement -assignees: '' - ---- - -**Important note** -Please note that only PrestoN is able to merge Pull Requests into master. - -**Related issue** -Please link the issue your feature is referring to. - -**Description** -Please write a clear and concise description of what the implementation does. - -**Screenshots (if appropriate)** -Please add before and after screenshots if there is a visible change. - -**Testing** -Has this feature been tested? -Please describe shortly how you tested it and whether there are any ramifications remaining. - -**Desktop (please complete the following information):** - - OS: [e.g. iOS] - - OS Version: [e.g. 22] - - FreeTube version: [e.g. 0.8] - -**Additional context** -Add any other context about the problem here.