Commit Graph

926 Commits

Author SHA1 Message Date
Aiz 1695605ab5
Remove deprecated @keypress + some accessability improvements (#2697)
* remove deprecated @keypress from top-nav

* remove deprecated @keypress from side-nav

* add role and tabindex to new window button

it could previously not be selected by tabbing over the buttons
2022-10-12 19:02:39 +02:00
absidue bc8261d970
Move colours from the store to the utils helper (#2710)
* Move colours from the store to the utils helper

* Use a single array for colours
2022-10-12 06:49:12 +00:00
Emma 3c7b143fce
Improving responsiveness in Settings (#2694)
* Removing a `width:auto` which was overriding

the width for a lot of .select-text

* Making the general-settings component not overflow

* Reducing margin in settings when window is narrow

* Moving invidious instance tooltip to reduce overflow

* Reducing the width of sliders to be 100% at maximum

Before this change, the preset width `380px` could easily
be wider than the window.

* Reducing overflow in Theme Settings

- Added breakpoint for theme `select`s
- Added breakpoint for the UI scale slider

* Reducing the remaining overflow in settings

This moves all of the tooltips slightly to the left
when the window is narrow to reduce overflow.

* Expanding the sponsorblock settings to full width

* Moving remaining tooltips into a fixed zone

* Floating the tooltip icon to the right

When the display is narrow, the tooltip
can sometimes overflow, and it is very
difficult to predict how it will overflow
if the tool tip icon comes directly after
a locale string.

This change floats those icons into a
centralized location where the tooltip
can be guaranteed to not overflow.

* Removing some irrelevant changes

* Reducing margin on switches

* Removing bottom margin on the last section

* Making room for overflow ellipsis

* Adding class  `.containsTooltip` to `ft-toggle`

This should make is easier to style the toggles
which contain tooltips specficially.

* Modifying the media query for tooltips

* Adding a media query to reduce data settings margin
2022-10-11 09:38:31 +02:00
efb4f5ff-1298-471a-8973-3d47447115dc 40859b5887
Update index.js (#2706) 2022-10-11 09:26:31 +08:00
absidue 22a5062334
Move calculateColorLuminance, calculatePublishedDate and buildVTTFileLocally out of the store (#2692) 2022-10-10 07:45:18 +00:00
Aiz 7ca6440a88
Add shortcuts for refresh buttons on Subscription, Trending, and Popular views (#2689)
* add shortcut to subscription refresh button

* add shortcut to most popular refresh button

* add shortcut to trending refresh button

* prevent refresh if currently loading
2022-10-09 09:10:57 -04:00
ChunkyProgrammer 41fee01217
Improve Importing Subscriptions (#2604)
* improve import

* fix merge conflicts

* dont add duplicate subscriptions, remove redundant "uniqueId"

* Update src/renderer/components/data-settings/data-settings.js

Co-authored-by: PikachuEXE <pikachuexe@gmail.com>

* fix unexpected errors

dont show toast when no errors. dont error when already subscribed

* remove check for legacy subscriptions

* rename method

* deduplicate importing code

* remove unused code

Co-authored-by: PikachuEXE <pikachuexe@gmail.com>
2022-10-09 03:08:34 +02:00
Emma 15d2cbbc8c
Fixing the logic for `isExternalLink` (#2687)
`.href` is computed from the real value of the attribute,
and this was causing an issue where isExternalLink would
classify links that should not be external links as external links.
2022-10-08 22:36:29 +02:00
Emma ec00ee3c04
Hiding two vjs controls when the screen is narrow (#2688)
- If picture and picture is disabled, the control can be hidden
when the available screen real estate is small.
- If the width is under 680, the video is already
almost the width of the entire window, so it makes sense
to hide it.
2022-10-08 22:35:28 +02:00
absidue 0f2fe16583
Move fetching of the sponsorblock segments out of the store (#2684) 2022-10-08 16:23:14 -04:00
absidue 9888005c91
Remove unused property from the invidious store (#2686) 2022-10-08 11:09:08 +08:00
Emma ac5341b309
Replacing `setImmediate` with `setTimeout` (#2683)
* Adding an import for setImmediate

`setImmediate` is a global in node, but
it is technically from the `timers` module,
and it is not global in web.

* Replacing node specific call to `setImmediate`

`setTimeout` is available globally in both node and web
2022-10-07 14:42:13 +00:00
absidue 5677c3182d
Remove jquery from the ft-player component (#2647) 2022-10-05 08:25:50 +00:00
absidue 5cd2e5a7d0
Replace jquery on the trending page (#2663) 2022-10-04 17:56:10 +00:00
absidue 28e07ec0aa
Replace jquery in the profile selector (#2664) 2022-10-04 17:55:55 +00:00
absidue f87014aedc
Replace jquery in live chat and improve the message styling (#2666)
* Replace jquery in live chat and improve the message styling

* Fix the automatic scrolling
2022-10-04 17:55:13 +00:00
Emma 38134bffa0
Centering update prompt card (#2668)
* Making the update prompt card fit inside the window

* Centering the update promptCard using flex
2022-10-04 05:08:26 +00:00
Emma 4a70726216
Adding logic to prevent virtual keyboards (#2667)
from closing the search bar
2022-10-04 10:54:31 +08:00
Emma f722340962
Prevent adding extra `/` when concatenating locale paths (#2665)
* Formatting the locales pathname to be more accurate

Before this change, the URL would refer
`https://localhost//static/locales/${locale}.json`
which technically works in most web browsers,
but it does not work in Cordova at all, so this
changes the links to be more accurately:
`https://localhost/static/locales/${locale}.json`

* Removing usage of `path` because it requires a polyfill/shim

* Linting the code
2022-10-02 23:38:01 +00:00
Aiz 6ddbce2e02
Add setting to disable automatic fetching of subscription feed (#2632)
* Add setting to disable automatic fetching of subscriptions

* rename from load to fetch. fix profile switch auto fetching

* add message for when auto fetch is disabled

* add strings to locale file

* Use a switch column grid for the subscription settings

This matches the layout other settings components

* remove import of now unused ft-flex-box component

* add variable to track if an attempt to fetch has been made.

used so the disable automatic fetch message doesn't block the
empty channels message.

* reduce distance between switches by adding compact=true

* edit tooltip wording
2022-09-29 22:29:47 -04:00
PikachuEXE 21371eec1a
* Update search in new window function to also copy original query text to new window search input (#2637) 2022-09-29 21:22:28 +00:00
absidue bc886af726
Implement chapters (#2224)
* Implement chapters

* Generate chapters locally for the Invidious API backend

* Performance improvements

* More performance improvements

* Improve chapters appearance and add compact mode for Invidious

* Update UI while seeking instead of afterwards

* Invidious extract chapters with range timestamps properly and duplicate chapters

* Minor code improvement

* Add accessibility labels and keyboard navigation

* Add chapter markers

* Fix missing newline at the bottom of ft-video-player.css

* Fix marker placement
2022-09-29 20:01:54 +00:00
absidue 206094aecd
Create video player buttons without jquery (#2636) 2022-09-29 13:15:30 +00:00
Emma f0deb78e6f
Hiding "Disable smooth scroll" option in web (#2638)
* Hiding "smooth-scroll" setting when not electron

- This feature requires the restart of electron and
doesn't work in web builds.

* Removing this comment

- A safeguard was added
- This function won't be called unless IS_ELECTRON is true
2022-09-29 12:24:10 +00:00
absidue 850ed6502c
Fix package.json getting embedded in the release builds (#2635) 2022-09-28 20:55:33 -04:00
Emma e2686dfe24
Fixing issue instance list not falling back (#2626)
- Expanded the fall-back to catch edge
cases where the instance list returns a
completely valid response of [] (an other-
wise useless response which doesn't throw
an error).
2022-09-27 22:05:12 +02:00
absidue c3f8a3561b
Replace jquery in ft-icon-button with vue functionality (#2617)
* Replace jquery in ft-icon-button with vue functionality

* Rename hide method to hideDropdown

* Fix typo in comment

Co-authored-by: ChunkyProgrammer <78101139+ChunkyProgrammer@users.noreply.github.com>

* Fix menu reappearing too soon

* Fix share menu buttons not triggering

Co-authored-by: ChunkyProgrammer <78101139+ChunkyProgrammer@users.noreply.github.com>
2022-09-27 08:16:56 -04:00
Aiz 498ae77ade
Improve styling of premiere date box (#2611)
* use 5px border radius instead of 5%

a 5% border radius will create an oval shape when height and width differ.
this doesn't look good.
5px radius looks better and is used in other places

* offset premiereDate by 12px from bottom left

Increases the offset a tiny amount and adds a left offset aswell.
This looks better than when it was previously only offset from the bottom.
I used 12px because it's what youtube uses.

* use flexbox to align items additional positioning with margins

vertically centes premiere icon and text with by making their parent a flexbox

sets a min width for the text instead of using a set width for the premiereDate

* change font size and weight of timestamp text

* remove uneeded line height styling

line height 1.2 did not affect anything

* fix indentation

* Update src/renderer/views/Watch/Watch.sass

Co-authored-by: absidue <48293849+absidue@users.noreply.github.com>

Co-authored-by: absidue <48293849+absidue@users.noreply.github.com>
2022-09-27 07:19:35 +08:00
absidue 6d1b0a63b6
Fix empty description box showing for the Invidious API (#2614)
* Fix empty description box showing for the Invidious API

* Add comment about HTML parsing
2022-09-26 20:36:41 +00:00
Aiz 148db553f5
Remove disable CORS Line. issue is fixed upstream (#2623)
issue was fixed in https://github.com/electron/electron/pull/25463

it will now be disabled when with webSecurity: false
2022-09-26 16:16:38 -04:00
absidue fa8d423bc6
Fix some development code not getting optimised out (#2605) 2022-09-26 16:15:13 -04:00
absidue 8e72e7fe5f
Replace jquery in top-nav component (#2620) 2022-09-26 16:14:21 -04:00
absidue c1a78d878e
Use native addEventListener instead of jquery's .on (#2612) 2022-09-25 08:44:16 +08:00
absidue facbbf6acf
Replace jquery $.param with native URLSearchParams (#2613) 2022-09-24 19:39:27 -04:00
Aiz c9c522a2b1
Use Intl.RelativeTimeFormat() for premiere upcoming time left (#2610)
* Improve premiere timestamp

Removes the unesseccary parts of the timestamp, year and seconds.

displays month as long name (eg., March)

* fix linting... forgot to add the file again before commit.

* get and use current locale set in freetube

this fixes issues where os locale and freetube locale don't match

* use 'default' when no locale is set in freetube.

this defaults to system locale

* use i18n to get locale and format date with intl

* format date with intl.datetimeformat

forgot to add file again after changes...

* use intl relative time format to format upcomingTimeLeft

* rename timeUnitI18nKey to just timeUnit

It's no longer used as a key and is no longer partial
2022-09-24 23:23:45 +00:00
absidue ac4cc4a611
Compress and lazy load locales (#2603)
* Compress and lazy load locales

* Remove index.html when loading the locales on the web

* Fix locale output path for web build
2022-09-24 11:06:50 -04:00
absidue 63946f7561
Add a settings section component to reduce duplicate code (#2609) 2022-09-24 09:12:11 +00:00
Emma 1512178489
Implementing showOpenDialog's web callback (#2608)
* Implementing the open file dialog in web

- Adding a new function to make loading files
from a dialog box easier in both web and electron

* Canceled should always be false

onchange is only triggered when the file picker
has a file path. If the user cancels, this function
is never called.

* Changing from `function ()` to `() => {`

* Adding a try around processing the history import

* Moving the try-catch to a smaller section

* Adding a listener to when the file picker is closed

* Fixing the grammar on my comment

* Refactoring playlist imports to use readFileFromDialog

* Refactoring handleFreetubeImportFile to use readFileFromDialog

* Refactoring handleYoutubeCsvImportFile to use readFileFromDialog

* Refactoring handleYoutubeImportFile to use readFileFromDialog

* Refactoring importOpmlYoutubeSubscriptions to use readFileFromDialog

* Refactoring importNewPipeSubscriptions to use readFileFromDialog

* Added a check

to prevent resolve from being called multiple times

* Moving the call to removeEventListener

to prevent this event from being triggered twice

* Adding extensions to the web file picker

* Hiding `Check for legacy subscriptions` in web

* Adding comments for better readability

* Correcting my vue syntax
2022-09-23 12:15:49 -04:00
ChunkyProgrammer 7822f7423e
Remove console.logs (#2606)
* remove console.logs

* use 'off' instead of 0
2022-09-23 09:04:10 +08:00
Bryan-Elliott Tam 420a91a072
Feature/new window right click (#2027)
* right click menu for open in a new window

* open video in new window when right click

* router link added to channel images for easier selection in the context of a context menu

* fix security bug user can visit other website via freetube

* simplify context menu entry condition

* createWindow in open new window adapted with the merged function

* Change the open new window selector for the origin of the page no matter the name of the website

* Keypress reintegrate into the code for accesibility

* Keypress reintegrate into the code for accesibility

* Fix style for sidenav subscription links

Co-authored-by: PikachuEXE <pikachuexe@gmail.com>
2022-09-22 13:03:18 +00:00
Aiz e90b9f4706
Improve premiere timestamp to be easier to read (#2559)
* Improve premiere timestamp

Removes the unesseccary parts of the timestamp, year and seconds.

displays month as long name (eg., March)

* fix linting... forgot to add the file again before commit.

* get and use current locale set in freetube

this fixes issues where os locale and freetube locale don't match

* use 'default' when no locale is set in freetube.

this defaults to system locale

* use i18n to get locale and format date with intl

* format date with intl.datetimeformat

forgot to add file again after changes...

* display year if current year is less than year of premiere date
2022-09-22 08:49:59 +08:00
absidue 061a7c8db1
Replace jquery getJSON and get with native fetch (#2591)
* Replace jquery getJSON and get with native fetch

* Remove unnecessary console.log
2022-09-21 07:05:03 +00:00
Emma 25d954f990
Cleaning up calls to the Clipboard API (#2597)
* Added a copyToClipboard function to utils

This should make it easier to handle errors which
result from the clipboard API (which are more likely
in web builds). This should also make it easier to handle
copying to clipboard in cordova builds by abstracting the
platform specific code out of the views and moving it
all into one function.

* Moved the $t function out of utils

* Removing locale snippets I was using and am not now

* Added function comment to copyToClipboard

* Adding some missing references

* Adding an additional check

* Re-reviewing my changes, I found a mistake

* Update src/renderer/store/modules/utils.js

Co-authored-by: absidue <48293849+absidue@users.noreply.github.com>

* Update static/locales/en-US.yaml

Co-authored-by: ChunkyProgrammer <78101139+ChunkyProgrammer@users.noreply.github.com>

* Reverting the language back to what it was previously

* Switching to using i18n.t()

instead of handling the translations myself.
Also, it looks like eslint removed a tab.

Co-authored-by: absidue <48293849+absidue@users.noreply.github.com>
Co-authored-by: ChunkyProgrammer <78101139+ChunkyProgrammer@users.noreply.github.com>
2022-09-21 15:00:21 +08:00
Emma b722435a88
Calling updateVisibleDataList on inputData update (#2601) 2022-09-21 08:01:00 +02:00
Emma c4722c9533
Implementing downloadMedia in web environments (#2602) 2022-09-21 08:00:34 +02:00
Aiz 7f6834d8f6
set height of watch page grid with auto in dual-column-template (#2588)
this ensures the page doesn't keep scrolling forever if live chat is enabled and recommended videos is disabled
2022-09-20 14:31:25 +00:00
PikachuEXE d8de7fe06f
* Implement last window's fullscreen state (#2495) 2022-09-20 08:49:45 -04:00
absidue 77c26638e1
Fully replace electron-debug with our own implementation (#2585) 2022-09-19 09:36:40 -04:00
absidue 76a9e5c3c4
Fix the localised description containing broken URLs (#2572)
* Fix the localised description containing broken URLs

* Fix hashtag handling in title and description
2022-09-19 08:49:30 -04:00
ChunkyProgrammer 8fa182e246
Properly localize numbers (#2557)
* localize numbers properly

* Remove tostring

Co-authored-by: Aiz <66974576+Aiz0@users.noreply.github.com>

Co-authored-by: Aiz <66974576+Aiz0@users.noreply.github.com>
2022-09-19 20:14:53 +08:00