tesses50
/
Ooui-tws-port
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #155 from mrange/pr/mrange/text_optimization 

Node.Text optimization
This commit is contained in:
Frank A. Krueger 2018-05-13 11:08:22 -07:00 committed by GitHub
parent 4f9f46ce38 18d198f6b6
commit 2c5efd7cf8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 52 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Ooui/Node.cs
View File

@ -35,6 +35,14 @@ namespace Ooui
return sb.ToString ();
}
set {
if (Children.Count == 1) {
var textNode = Children[0] as TextNode;
if (textNode != null) {
textNode.Text = value;
return;
}
}
ReplaceAll (new TextNode (value ?? ""));
}
}

44
Tests/NodeTests.cs
View File

@ -1,4 +1,5 @@
using System;
using System.Text;
#if NUNIT
using NUnit.Framework;
@ -68,5 +69,48 @@ namespace Tests
p.Receive (Message.Event (b.Id, "change", "please work"));
Assert.AreEqual ("please work", b.Value);
}
[TestMethod]
public void Text ()
{
var div = new Div ();
// Log tracks all messages sent due to updates
var log = new StringBuilder ();
log.AppendLine ();
void Parent_MessageSent (Message obj)
{
log.AppendLine (obj.ToString ());
}
div.MessageSent += Parent_MessageSent;
var divId = div.Id;
log.AppendLine ("#1 - Inserts new text node");
div.Text = "Hello";
Assert.AreEqual (1, div.Children.Count);
var text = div.Children[0];
var textId = text.Id;
Assert.AreEqual ("Hello", div.Text);
Assert.AreEqual ("Hello", text.Text);
log.AppendLine ("#2 - Sets text node text to There");
div.Text = "There";
Assert.AreEqual ("There", div.Text);
Assert.AreEqual ("There", text.Text);
var expected = string.Format(@"
#1 - Inserts new text node
{{""m"":""call"",""id"":""{0}"",""k"":""insertBefore"",""v"":[""{1}"",null]}}
#2 - Sets text node text to There
{{""m"":""set"",""id"":""{1}"",""k"":""data"",""v"":""There""}}
", divId, textId).Replace ("\r\n", "\n");
var actual = log.ToString ().Replace ("\r\n", "\n");
Assert.AreEqual (expected, actual);
}
}
}