tesses50
/
Ooui-tws-port
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Don't keep ASP.NET sessions around

This commit is contained in:
Frank A. Krueger 2018-02-21 15:40:12 -08:00
parent 4ef14afc7f
commit 7267bb2687
No known key found for this signature in database
GPG Key ID: 0471C67474FFE664
1 changed files with 11 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
Ooui.AspNetCore/WebSocketHandler.cs
View File

@ -11,21 +11,21 @@ namespace Ooui.AspNetCore
{ {
public static string WebSocketPath { get; set; } = "/ooui.ws"; public static string WebSocketPath { get; set; } = "/ooui.ws";
public static TimeSpan SessionTimeout { get; set; } = TimeSpan.FromMinutes (5); public static TimeSpan SessionTimeout { get; set; } = TimeSpan.FromMinutes (1);
static readonly ConcurrentDictionary<string, ActiveSession> activeSessions = static readonly ConcurrentDictionary<string, PendingSession> pendingSessions =
new ConcurrentDictionary<string, ActiveSession> (); new ConcurrentDictionary<string, PendingSession> ();
public static string BeginSession (HttpContext context, Element element) public static string BeginSession (HttpContext context, Element element)
{ {
var id = Guid.NewGuid ().ToString ("N"); var id = Guid.NewGuid ().ToString ("N");
var s = new ActiveSession { var s = new PendingSession {
Element = element, Element = element,
LastConnectTimeUtc = DateTime.UtcNow, CreateTimeUtc = DateTime.UtcNow,
}; };
if (!activeSessions.TryAdd (id, s)) { if (!pendingSessions.TryAdd (id, s)) {
throw new Exception ("Failed to schedule pending session"); throw new Exception ("Failed to schedule pending session");
} }
@ -62,19 +62,18 @@ namespace Ooui.AspNetCore
// //
// Clear old sessions // Clear old sessions
// //
var toClear = activeSessions.Where (x => (DateTime.UtcNow - x.Value.LastConnectTimeUtc) > SessionTimeout).ToList (); var toClear = pendingSessions.Where (x => (DateTime.UtcNow - x.Value.CreateTimeUtc) > SessionTimeout).ToList ();
foreach (var c in toClear) { foreach (var c in toClear) {
activeSessions.TryRemove (c.Key, out var _); pendingSessions.TryRemove (c.Key, out var _);
} }
// //
// Find the pending session // Find the pending session
// //
if (!activeSessions.TryGetValue (id, out var activeSession)) { if (!pendingSessions.TryRemove (id, out var activeSession)) {
BadRequest ("Unknown `id`"); BadRequest ("Unknown `id`");
return; return;
} }
activeSession.LastConnectTimeUtc = DateTime.UtcNow;
// //
// Set the element's dimensions // Set the element's dimensions
@ -102,10 +101,10 @@ namespace Ooui.AspNetCore
await session.RunAsync ().ConfigureAwait (false); await session.RunAsync ().ConfigureAwait (false);
} }
class ActiveSession class PendingSession
{ {
public Element Element; public Element Element;
public DateTime LastConnectTimeUtc; public DateTime CreateTimeUtc;
} }
} }
} }